Skip to content

Fix GH-19476: pipe operator fails to correctly handle returning by reference #19478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

Fix GH-19476: pipe operator fails to correctly handle returning by reference #19478

merged 1 commit into from
Aug 14, 2025

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Aug 14, 2025 •
edited
Loading

Fix #19476

Modifying the compiler to add the pipe AST node to the cases of zend_is_call() seems to work well.

@alexandre-daubois alexandre-daubois marked this pull request as ready for review August 14, 2025 11:42
@TimWolla TimWolla requested a review from iluuu1994 August 14, 2025 11:53
iluuu1994
iluuu1994 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@iluuu1994 iluuu1994 merged commit 6009b8a into php:master Aug 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipe operator (|>) fails to correctly handle returning by reference
2 participants
@alexandre-daubois @iluuu1994