Deprecate using null as an array offset and when calling array_key_exists()
#19511
+894
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
2 times, most recently
from
b1629ed to
6b521a3
Compare
TimWolla
reviewed
Aug 19, 2025
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
3 times, most recently
from
472c3c6 to
baeda1f
Compare
DanielEScherzer
requested changes
Aug 20, 2025
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
from
baeda1f to
a6d44e0
Compare
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
2 times, most recently
from
d5fd9e5 to
a602268
Compare
|
Still a few tests to fix but we're getting closer |
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
2 times, most recently
from
6f50c89 to
e508fcc
Compare
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
4 times, most recently
from
8f22921 to
dc5049b
Compare
arnaud-lb
reviewed
Aug 21, 2025
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
2 times, most recently
from
c47e2b5 to
58878be
Compare
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
from
422c6e8 to
bf163af
Compare
TimWolla
reviewed
Aug 22, 2025
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
17 times, most recently
from
7c574af to
a1564b1
Compare
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
2 times, most recently
from
736aac0 to
1bf2dbd
Compare
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
3 times, most recently
from
ed3ac5b to
8324606
Compare
alexandre-daubois
force-pushed
the
array-key-exists-null
branch
from
8324606 to
95306bb
Compare
Girgias
approved these changes
Aug 23, 2025
| bool(false) | ||
|
|
||
| -- Iteration 20 -- | ||
|
|
||
| Warning: Resource ID#%d used as offset, casting to integer (%d) in %s on line %d | ||
| Warning: Resource ID#5 used as offset, casting to integer (5) in %s on line %d |
There was a problem hiding this comment.
Please continue to use the printf specifiers for the ressource ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19468
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
cc @Girgias