Convert some warnings to Errors in BZip2 #4984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Dec 8, 2019
nikic
reviewed
Jan 3, 2020
nikic
reviewed
Jan 3, 2020
Girgias
force-pushed
the
bz2-warnings-to-error
branch
from
cc46f1b to
a3695ba
Compare
kocsismate
reviewed
Jan 7, 2020
|
@cmb69 I was thinking about how to best collect all the warning promotions to a change log (regarding https://externals.io/message/107931). Wouldn't using a separate GitHub label (similar to stubs) help there? |
Girgias
force-pushed
the
bz2-warnings-to-error
branch
from
a3695ba to
9c612e0
Compare
|
@kocsismate, yes, I think a label would be useful. Any idea on how to name it (and which color to choose)? |
|
My preferences are |
|
Is that okay? |
|
Of course! :) Thanks! |
nikic
approved these changes
Jan 8, 2020
cmb69
reviewed
Jan 8, 2020
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.