Convert warning to assetion in MySQL PDO driver #6120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
Girgias
force-pushed
the
mysql-pdo-warning-to-assert
branch
from
ddff69e to
8215f65
Compare
nikic
reviewed
Sep 14, 2020
ext/pdo_mysql/pdo_mysql.c
Outdated
| php_error_docref(NULL, E_WARNING, "Provided PDO instance is not using MySQL but %s", dbh->driver->driver_name); | ||
| return NULL; | ||
| } | ||
| ZEND_ASSERT(dbh->driver == &pdo_mysql_driver); |
There was a problem hiding this comment.
The above !dbh check can be an assertion, but I don't think this one can be. The function accepts a generic zval, so there's no guarantee it uses the mysql driver.
The whole "reverse API" doesn't appear to be actually used inside PHP (looking around, it may be intended for mysqlnd_uh extension). Maybe it can be dropped in the future, but for now I'd leave it alone.
Girgias
force-pushed
the
mysql-pdo-warning-to-assert
branch
from
8215f65 to
6d762b8
Compare
nikic
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see how this can happen, and that seems like a bug if it does.