Error on resource ID space overflow #7428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgolemon
approved these changes
Aug 30, 2021
|
Just to note, don't forget to note the change in behaviour in upgrading please ... |
|
@krakjoe This is a bug fix for PHP 7.4, I don't think anyone is going to see an UPGRADING note there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When more than INT_MAX resource are created, throw a fatal error, rather than reusing already allocated IDs, which will result in assertion failure or crashes down the line.
This doesn't really fix anything, but it makes the failure cause a whole lot more obvious. Inspired by https://bugs.php.net/bug.php?id=81399.