Add some const qualifiers in zend_string/hash #8304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
hash-const-qualifiers
branch
from
8289d72 to
13d7700
Compare
morrisonlevi
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
These changes look good to me. I have a small suggestion to cast the result of zend_string_hash_val to void. This is a convention that some linters understand that says "I'm knowingly not using the result here." I've found it generally to be useful. What do you think?
Co-authored-by: Levi Morrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused as to why most of the APIs did not have a const modifier until I actually added them and got reminded that
zend_string_hash_func()needs thezend_stringto be mutable, so not sure how worthwhile these changes actually are.