Improve GraphQL caching for large queries #928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pimcore limits caching to a maximum of 50 items per request. For large GraphQL queries, this limit can easily be exceeded because every object loaded during query resolution is added to the cache queue with priority 0. When the queue is truncated, only the top 50 items (by priority) are retained. This commit increases the priority of the final GraphQL query result, ensuring this is more likely to be cached despite the 50-item limit.
|
ghost
added
the
|
@gajdusek Could you please resolve the conflicts? Thanks |
|
can't be merged anymore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pimcore limits caching to a maximum of 50 items per request. For large GraphQL queries, this limit can easily be exceeded because every object loaded during query resolution is added to the cache queue with priority 0. When the queue is truncated, only the top 50 items (by priority) are retained.
This commit increases the priority of the final GraphQL query result, ensuring this is more likely to be cached despite the 50-item limit.