Skip to content

Added additional env params #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2024.x
Choose a base branch
from
Open

Added additional env params #213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
662bf4b
Added additional env params
bluvulture Nov 29, 2024
584bddb
Added Rabbitmq url to params
bluvulture Dec 2, 2024
96534d7
Added Rabbitmq url to params
bluvulture Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ services:
PIMCORE_INSTALL_MYSQL_PORT: 3306
PIMCORE_INSTALL_MYSQL_HOST_SOCKET: db
PIMCORE_INSTALL_MYSQL_DATABASE: pimcore
GOTENBERG_IP: "1.2.3.4"
Copy link
Member

@brusch brusch Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GOTENBERG_IP: "1.2.3.4"
GOTENBERG_HOST: "gotenberg"

Same here, we need to use the proper config, otherwise Gotenberg won't work when having the config in place using the env vars.
Maybe we should also think about the naming, e.g. GOTENBERG_HOST is more specific? 🤔 We'd need to change this in pimcore/paas then as well.

GOTENBERG_PORT: "3000"
PLATFORM_PROJECT_ENTROPY: "1234567890"
REDIS_HOST: "redis"
REDIS_PORT: "6379"
PIMCORE_TOKEN: "1234567890"
RABBITMQ_URL: "amqp://user:pass@rabbitmq:1234"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RABBITMQ_URL: "amqp://user:pass@rabbitmq:1234"
RABBITMQ_URL: "amqp://rabbitmq:5672"

Here we should use the proper port, otherwise it won't work out of the box.

depends_on:
db:
condition: service_healthy
Expand Down