Skip to content

add tiflash config storage.temp #20151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 30, 2025
Merged

add tiflash config storage.temp #20151

merged 13 commits into from
Sep 30, 2025

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Apr 2, 2025 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2025
@guo-shaoge
Copy link
Contributor Author

related tiflash pr: pingcap/tiflash#10035

@guo-shaoge
fix
a3d5172 
Signed-off-by: guo-shaoge <[email protected]>
@Oreoxmt Oreoxmt self-assigned this Apr 2, 2025
@Oreoxmt Oreoxmt self-requested a review April 2, 2025 09:35
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Apr 2, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 2, 2025
@Oreoxmt Oreoxmt added the v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. label Apr 2, 2025
windtalker
windtalker approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 2, 2025

@windtalker: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Apr 2, 2025
@guo-shaoge
fix
5cf8510 
Signed-off-by: guo-shaoge <[email protected]>
@Oreoxmt Oreoxmt added v9.1 v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. and removed v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. v9.1 labels Apr 2, 2025
@guo-shaoge
fix
14d3410 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2025
@guo-shaoge guo-shaoge changed the title add tiflash config max_spilled_bytes add tiflash config storage.tmp Apr 15, 2025
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 15, 2025
guo-shaoge
guo-shaoge commented Apr 15, 2025
View reviewed changes
@guo-shaoge
fix temp
ff9a5ba 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
954467b 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
803f67f 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2025

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Apr 28, 2025
View reviewed changes
@guo-shaoge
Copy link
Contributor Author

other LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 10, 2025
@Oreoxmt Oreoxmt mentioned this pull request Jul 10, 2025
Merged
16 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 10, 2025
Oreoxmt
Oreoxmt reviewed Jul 18, 2025
View reviewed changes
qiancai
qiancai approved these changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-10 10:59:39.812293767 +0000 UTC m=+2170232.535472784: ☑️ agreed by Oreoxmt.
  • 2025-07-18 07:42:53.331737015 +0000 UTC m=+2849626.054915997: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 30, 2025

/approve

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 30, 2025

/unhold

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 30, 2025
@ti-chi-bot ti-chi-bot bot merged commit ee80d94 into pingcap:master Sep 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@windtalker windtalker windtalker approved these changes

@qiancai qiancai qiancai approved these changes

@joey-yez joey-yez joey-yez approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guo-shaoge @Oreoxmt @windtalker @qiancai @joey-yez @JaySon-Huang