add the prefix dm- to the filenames for some DM dev docs #869

qiancai · 2021-12-21T03:45:51Z

What is changed, added, or deleted? (Required)

As a preparation step of merging DM master docs to TiDB master docs, this PR makes the following changes:

For filenames that already exist in TiDB master docs (for example, alert-rules.md), add the prefix dm- to avoid filename conflicts during the merge, update the corresponding doc links, and add the aliases for the filename changes.
For filenames that might look confusing after merging to TiDB master docs (for example, benchmark-v5.3.0.md), add the prefix dm- to the filenames, update the corresponding doc links, and add the aliases for the filename changes.

Please note that the only purpose of this PR is to show the DM filename changes before merging to TiDB Docs, so this PR is not intended to be merged.

Which DM version(s) do your changes apply to? (Required)

master (the latest development version)
v5.3 (TiDB DM 5.3 versions)
v2.0 (TiDB DM 2.0 versions)
v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-12-21T03:45:52Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

shichun-0415

LGTM

zh/dm-daily-check.md

Co-authored-by: TomShawn <[email protected]>

… into rename_5_doc_files

TomShawn · 2021-12-21T11:32:29Z

en/dm-overview.md

 title: Data Migration Overview
 summary: Learn about the Data Migration tool, the architecture, the key components, and features.
-aliases: ['/docs/tidb-data-migration/dev/overview/']
+aliases: ['/docs/tidb-data-migration/dev/overview/','/tidb-data-migration/dev/overview.md/]


Suggested change

aliases: ['/docs/tidb-data-migration/dev/overview/','/tidb-data-migration/dev/overview.md/]

aliases: ['/docs/tidb-data-migration/dev/overview/','/tidb-data-migration/dev/overview/]

TomShawn · 2021-12-21T11:33:40Z

zh/dm-overview.md

 ---
 title: Data Migration 简介
-aliases: ['/docs-cn/tidb-data-migration/dev/overview/','/docs-cn/tools/dm/overview/']
+aliases: ['/docs-cn/tidb-data-migration/dev/overview/','/docs-cn/tools/dm/overview/','/zh/tidb-data-migration/dev/overview.md/]


Suggested change

aliases: ['/docs-cn/tidb-data-migration/dev/overview/','/docs-cn/tools/dm/overview/','/zh/tidb-data-migration/dev/overview.md/]

aliases: ['/docs-cn/tidb-data-migration/dev/overview/','/docs-cn/tools/dm/overview/','/zh/tidb-data-migration/dev/overview/]

TomShawn · 2021-12-21T11:35:14Z

en/dm-key-features.md

 title: Key Features
 summary: Learn about the key features of DM and appropriate parameter configurations.
-aliases: ['/docs/tidb-data-migration/dev/feature-overview/','/tidb-data-migration/dev/feature-overview']
+aliases: ['/docs/tidb-data-migration/dev/feature-overview/','/tidb-data-migration/dev/feature-overview','/tidb-data-migration/dev/key-features.md/]


Global comment: aliases 是浏览器里实际出现的 URL，不以 .md 结尾。请批量去掉 aliases 中的 .md。

TomShawn · 2021-12-21T11:35:52Z

zh/dm-key-features.md

 title: 主要特性
 summary: 了解 DM 的各主要功能特性或相关的配置选项。
-aliases: ['/docs-cn/tidb-data-migration/dev/key-features/','/docs-cn/tidb-data-migration/dev/feature-overview/']
+aliases: ['/docs-cn/tidb-data-migration/dev/key-features/','/docs-cn/tidb-data-migration/dev/feature-overview/','/zh/tidb-data-migration/dev/key-features.md/]


Suggested change

aliases: ['/docs-cn/tidb-data-migration/dev/key-features/','/docs-cn/tidb-data-migration/dev/feature-overview/','/zh/tidb-data-migration/dev/key-features.md/]

aliases: ['/docs-cn/tidb-data-migration/dev/key-features/','/docs-cn/tidb-data-migration/dev/feature-overview/','/zh/tidb-data-migration/dev/key-features/]

TomShawn · 2021-12-21T11:40:06Z

en/dm-benchmark-v5.3.0.md

 ---
 title: DM 5.3.0 Benchmark Report
 summary: Learn about the performance of 5.3.0.
+aliases: ['/tidb-data-migration/dev/benchmark-v5.3.0.md/]


TomShawn · 2021-12-22T05:45:08Z

LGTM

add the prefix dm- to the filenames for 5 DM docs

f45c49c

ti-chi-bot requested a review from shichun-0415 December 21, 2021 03:45

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021

qiancai added the translation/done This PR has been translated. label Dec 21, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 21, 2021

qiancai requested a review from TomShawn December 21, 2021 03:50

shichun-0415 approved these changes Dec 21, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2021

TomShawn reviewed Dec 21, 2021

View reviewed changes

zh/dm-daily-check.md Outdated Show resolved Hide resolved

qiancai and others added 3 commits December 21, 2021 19:14

Update zh/dm-daily-check.md

4d49ace

Co-authored-by: TomShawn <[email protected]>

rename_files

a030378

Merge branch 'rename_5_doc_files' of https://github.com/qiancai/docs-dm…

06ab253

… into rename_5_doc_files

qiancai changed the title ~~add the prefix dm- to the filenames for 5 DM docs~~ add the prefix dm- to the filenames for DM docs Dec 21, 2021

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021

qiancai added 2 commits December 21, 2021 19:25

Update dm-handle-alerts.md

5c478e7

Update dm-handle-alerts.md

a77ff49

TomShawn reviewed Dec 21, 2021

View reviewed changes

Update dm-alert-rules.md

9fe9d2d

TomShawn reviewed Dec 21, 2021

View reviewed changes

revert_changes

beb13c5

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 21, 2021

revert_changes

9aa3312

ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2021

ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 21, 2021

qiancai added 3 commits December 21, 2021 19:50

Update dm-handle-alerts.md

2f841d4

Update dm-alert-rules.md

88ae02d

Update dm-handle-alerts.md

c7e5cc8

TomShawn added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2021

qiancai changed the title ~~add the prefix dm- to the filenames for DM docs~~ add the prefix dm- to the filenames for some DM dev docs Dec 23, 2021

qiancai closed this Feb 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add the prefix dm- to the filenames for some DM dev docs #869

add the prefix dm- to the filenames for some DM dev docs #869

Uh oh!

qiancai commented Dec 21, 2021 •

edited

Loading

Uh oh!

ti-chi-bot commented Dec 21, 2021 •

edited

Loading

Uh oh!

shichun-0415 left a comment

Uh oh!

Uh oh!

TomShawn Dec 21, 2021

Uh oh!

TomShawn Dec 21, 2021

Uh oh!

TomShawn Dec 21, 2021

Uh oh!

TomShawn Dec 21, 2021

Uh oh!

TomShawn Dec 21, 2021

Uh oh!

TomShawn commented Dec 22, 2021

Uh oh!

Uh oh!

	aliases: ['/docs/tidb-data-migration/dev/overview/','/tidb-data-migration/dev/overview.md/]
	aliases: ['/docs/tidb-data-migration/dev/overview/','/tidb-data-migration/dev/overview/]

	aliases: ['/docs-cn/tidb-data-migration/dev/overview/','/docs-cn/tools/dm/overview/','/zh/tidb-data-migration/dev/overview.md/]
	aliases: ['/docs-cn/tidb-data-migration/dev/overview/','/docs-cn/tools/dm/overview/','/zh/tidb-data-migration/dev/overview/]

add the prefix dm- to the filenames for some DM dev docs #869

add the prefix dm- to the filenames for some DM dev docs #869

Uh oh!

Conversation

qiancai commented Dec 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Dec 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shichun-0415 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomShawn Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn commented Dec 22, 2021

Uh oh!

Uh oh!

qiancai commented Dec 21, 2021 •

edited

Loading

ti-chi-bot commented Dec 21, 2021 •

edited

Loading