Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Fix broken link in shard-merge-best-practices.md and addd a missing section #900

Merged
merged 6 commits into from
May 23, 2022
Merged

Fix broken link in shard-merge-best-practices.md and addd a missing section #900

merged 6 commits into from
May 23, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented May 23, 2022 •
edited by shichun-0415
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

  1. Fix broken link in shard-merge-best-practices.md reported by Broken Link Detected #898.
  2. Fix a section that is missing in translation from zh: add detailed checks and steps for shard-merge scenario #698 to update toc.md, shard-merge.md, add incremental data migration document #748

Which DM version(s) do your changes apply to? (Required)

Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.

  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added area/best-practices Adds or updates TiDB best practices. needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. labels May 23, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label May 23, 2022
@ti-chi-bot ti-chi-bot requested a review from shichun-0415 May 23, 2022 04:06
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2022
@shichun-0415 shichun-0415 changed the title Fix broken link in shard-merge-best-practices.md Fix broken link in shard-merge-best-practices.md and addd a missing section May 23, 2022
Oreoxmt
Oreoxmt commented May 23, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
TomShawn
TomShawn reviewed May 23, 2022
View reviewed changes
TomShawn
TomShawn approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@shichun-0415 shichun-0415 mentioned this pull request May 23, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 removed the needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. label May 23, 2022
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 23, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ddb8414

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@ti-chi-bot ti-chi-bot merged commit 2b5ac2e into pingcap:release-5.3 May 23, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #901.

This was referenced May 23, 2022
Merged
Merged
ti-chi-bot added a commit that referenced this pull request May 23, 2022
@ti-chi-bot
Fix broken link in shard-merge-best-practices.md and addd a missing s…
469938f 
…ection (#900) (#901)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@TomShawn TomShawn TomShawn approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/best-practices Adds or updates TiDB best practices. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oreoxmt @ti-chi-bot @shichun-0415 @TomShawn