-
Notifications
You must be signed in to change notification settings - Fork 704
hardware-and-software-requirements: add tiproxy #21840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation by incorporating the necessary hardware and software specifications for the TiProxy component. This ensures that users have comprehensive guidelines for deploying TiProxy, covering both development/testing and production scenarios, thereby enhancing the clarity and completeness of the system requirements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
/cc @kissmydb |
@dveeden: GitHub didn't allow me to request PR reviews from the following users: kissmydb. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Note that TiProxy is an optional component, just like TiFlash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds hardware and software requirements for TiProxy to the documentation. The changes are accurate and align with the information in other TiProxy-related documents. I've added a couple of minor suggestions to specify the storage size for TiProxy for better consistency and clarity. Overall, a good addition to the documentation.
| TiKV | 8 core+ | 32 GB+ | SAS, 200 GB+ | Gigabit network card | 3 | | ||
| TiFlash | 32 core+ | 64 GB+ | SSD, 200 GB+ | Gigabit network card | 1 | | ||
| TiCDC | 8 core+ | 16 GB+ | SAS, 200 GB+ | Gigabit network card | 1 | | ||
| TiProxy | 4 core+ | 8 GB+ | SAS | Gigabit network card | 1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other components in the table, consider specifying a minimum storage size. Since TiProxy is a stateless proxy, its storage is mainly for logs and binaries. A size such as 30 GB+
would be appropriate for development and test environments, similar to TiDB's log disk requirement.
| TiProxy | 4 core+ | 8 GB+ | SAS | Gigabit network card | 1 | | |
| TiProxy | 4 core+ | 8 GB+ | SAS, 30 GB+ | Gigabit network card | 1 | |
| TiFlash | 48 core+ | 128 GB+ | 1 or more SSDs | 10 Gigabit network card (2 preferred) | 2 | | ||
| TiCDC | 16 core+ | 64 GB+ | SSD | 10 Gigabit network card (2 preferred) | 2 | | ||
| Monitor | 8 core+ | 16 GB+ | SAS | Gigabit network card | 1 | | ||
| TiProxy | 8 core+ | 16 GB+ | SAS | 10 Gigabit network card (2 preferred) | 2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other components in this table, consider specifying a storage size for TiProxy. For a production environment, a size like 100 GB+
would be a safe recommendation to account for logs and potential traffic capture files.
| TiProxy | 8 core+ | 16 GB+ | SAS | 10 Gigabit network card (2 preferred) | 2 | | |
| TiProxy | 8 core+ | 16 GB+ | SAS, 100 GB+ | 10 Gigabit network card (2 preferred) | 2 | |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?