backend, net: close the client connection when the backend is down #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #195
Problem Summary:
On the serverless tier, when the client is idle for 5 minutes, the backend will quit. But the TiProxy doesn't know the backend quits because it's still reading the client. Then, the serverless tier thinks the connection is still alive and then wakes up a new TiDB instance.
So, TiProxy should always detect the backend and disconnect the client when the backend quits.
What is changed and how it works:
BackendConnMgr
to check the backend periodically in the background goroutinePacketIO.conn
with a buffer and addPacketIO.IsPeerActive()
NewBackendConnMgr
to make them configurable in the testscheckConnClosed4Proxy
. It never worked before becausets.mp.err
is not checkedCheck List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.