Skip to content

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Sep 3, 2025

What problem does this PR solve?

Problem Summary:

What is changed and how it works:

This was deprecated on Fri Apr 12 10:00:22 2024 +0800 by #504

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from djshow832 and xhebox September 3, 2025 07:07
@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 3, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@d3f8304). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/tiproxy/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage        ?   67.23%           
=======================================
  Files           ?      129           
  Lines           ?    12260           
  Branches        ?        0           
=======================================
  Hits            ?     8243           
  Misses          ?     3435           
  Partials        ?      582           
Flag Coverage Δ
unit 67.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold this PR because it breaks compatibility. Some tools may have added these options. It makes them unable to start without removing the options.

@dveeden
Copy link
Contributor Author

dveeden commented Sep 5, 2025

/hold

@dveeden
Copy link
Contributor Author

dveeden commented Sep 5, 2025

Do we now which tools might use these? TiUP Cluster? TiUP Playground? TiDB Operator? Maybe we should try go get those fixed as the options currently don't do anything.

Should we add some warnings/errors on stderr if anyone calls tiproxy with the deprecated (noop) options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants