test: move hooks.test.js to the node test runner #2185
Conversation
test/hooks.test.js
Outdated
| function match (t, obj, expected) { | ||
| const checkObj = Object.keys(expected).reduce((acc, key) => { | ||
| acc[key] = obj[key] | ||
| return acc | ||
| }, {}) | ||
|
|
||
| t.assert.deepStrictEqual(checkObj, expected) | ||
| } |
There was a problem hiding this comment.
It's not available in v20 yet, but I would prefer we use nodejs/node#54630. In the interim, we can copy https://github.com/newrelic/node-newrelic/blob/ebf3aa946be1e6802b567f2bfeef0b0c13613375/test/lib/custom-assertions/match.js into a file like test/assert-match.js. I'm sure it will be used in more suites than this one.
There was a problem hiding this comment.
@jsumners done. Other PRs need this match assertion. I'll wait for this one to be merged before refactoring them.
|
Can we get match published as an npm module? Then it’d be less problematic. (This code is only used in tests and not really a problem anyway). |
|
That's a fair solution. I can do it with my account after work. |
|
@Puppo please use https://www.npmjs.com/package/@jsumners/assert-match npm install -D @jsumners/assert-match |
Done! |
3 participants
This PR moves
hooks.test.jsto the node test runner