Skip to content

Modular Package Types #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c7ff1e3
setup rollup and jest typescript configurations
Mar 2, 2023
0f021d3
add shared react types package
Mar 2, 2023
9f6def8
convert react-invariant to TS
Mar 2, 2023
ae71f42
convert react-modular to typescript
Mar 2, 2023
e847701
convert react-fiber-react-18 to typescript
Mar 2, 2023
c9940ea
convert react-components-pixi-7 to typescript
Mar 2, 2023
5451cb4
convert pixi-react to typescript
Mar 2, 2023
b50b962
convert react-animated to typescript
Mar 2, 2023
e42c3b3
convert sandbox to TS
Mar 2, 2023
51ee819
try to fix ci tests
Mar 2, 2023
3b3b7bf
fix ci command
Mar 2, 2023
477718b
add dependency for test:types
Mar 2, 2023
5890e8c
fix test:ci command, remove test:types since build will fail anyway
Mar 2, 2023
9ea08cd
add test:ci nx dependency
Mar 2, 2023
25702bd
dupe tsconfig for sandbox package so it works on codesandbox
Mar 2, 2023
65c4549
does nx wait for postbuild scripts to run before continuing?
Mar 3, 2023
dae95f9
log built files after each package is built
Mar 3, 2023
2710bf7
try node 18
Mar 3, 2023
9def5b2
remove canvas dep
Mar 3, 2023
4e419ed
switch for npm ci install
Mar 3, 2023
8aa8cc4
don't run tests in parallel?
Mar 3, 2023
e98c668
type tweaks
Mar 6, 2023
6b6bfd8
add separate Instance type so parent and child method type completion…
Mar 13, 2023
9348492
maybe it's legit broken :)
Mar 28, 2023
64806d9
try a GH action instead of circle
Mar 29, 2023
33d70ff
trigger GH actions
Mar 30, 2023
ba095c2
skip nx cache
Mar 31, 2023
3e08d61
remove build logger
Mar 31, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: circleci/node:lts
- image: cimg/node:18.13.0

working_directory: ~/repo

Expand All @@ -16,7 +16,7 @@ jobs:
- v{{ checksum "_cache_version" }}-dependencies-{{ checksum "package.json" }}
- v{{ checksum "_cache_version" }}-dependencies-

- run: npm install
- run: npm ci --legacy-peer-deps

- save_cache:
paths:
Expand All @@ -25,4 +25,4 @@ jobs:

- run: npm run lint

- run: npm test --ci --silent
- run: npm run test:ci --ci --silent
10 changes: 9 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,22 @@ module.exports = {
'packages/*/index.d.ts',
'**/test/__fixtures__',
],
globals: {
React: true,
JSX: true,
},
rules: {
'no-empty-function': 0,
'no-prototype-builtins': 0,
'spaced-comment': [1, 'always', { markers: ['/'] }],
'@typescript-eslint/triple-slash-reference': [1, { path: 'always' }],
'@typescript-eslint/consistent-type-imports': [1, { disallowTypeAnnotations: false }],
'@typescript-eslint/no-parameter-properties': 1,
'@typescript-eslint/type-annotation-spacing': 1
'@typescript-eslint/type-annotation-spacing': 1,
'@typescript-eslint/ban-ts-comment': [
'error',
{ 'ts-ignore': 'allow-with-description' },
],
},
overrides: [
{
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: PR

on: [ pull_request ]

jobs:
pr:
name: PR
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18'
cache: 'npm'
- run: npm ci --legacy-peer-deps
- run: npm run lint
- run: npm run test:ci:force --ci --silent
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ node_modules/
**/dist/
packages/*/stats.html
.eslintcache
.prettierrc
.run
10 changes: 9 additions & 1 deletion nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"cacheableOperations": [
"build",
"lint",
"test"
"test",
"test:ci",
"test:types"
],
"accessToken": "ZjQ3OWVmMTAtMTBlYS00YmJkLTk1ZjMtNmM5MWQ0YWFhYzY4fHJlYWQtd3JpdGU=",
"scan": true
Expand All @@ -24,6 +26,12 @@
},
"test": {
"dependsOn": ["^build"]
},
"test:ci": {
"dependsOn": ["^build"]
},
"test:types": {
"dependsOn": ["^build"]
}
},
"namedInputs": {
Expand Down
Loading