Skip to content

specify supported node version #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022
Merged

specify supported node version #387

merged 1 commit into from
Oct 27, 2022

Conversation

phoenixy1
Copy link
Contributor

prevents running the quickstart with node 17 or later, which are currently unsupported

Copy link
Contributor

@ToddKerpelman ToddKerpelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve for expediency, but we should
a) Determine if there's a minimum required version of node, and
b) Figure out if node 18 (the latest LTS version as of Tuesday) works

@@ -57,5 +57,8 @@
"immer": "9.0.6",
"ssri": "8.0.1",
"glob-parent": "5.1.2"
},
"engines": {
"node": "<17.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a minimum version here.

@phoenixy1 phoenixy1 merged commit 2066f73 into master Oct 27, 2022
SpencerHHurst pushed a commit to SpencerHHurst/quickstart that referenced this pull request Jul 10, 2024
fisherrjd pushed a commit to fisherrjd/quickstart that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants