Skip to content

Make sprockets dependency optional #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Conversation

joker-777
Copy link

It looks like sprockets will be soon replaced by propshaft. It would be great if we could make the sprockets dependency optional. (#403)

@gap777
Copy link

gap777 commented Oct 18, 2022

@ldlsegovia @GabrielLyonB et al... this PR removes a dependency upon sassc-rails, which happens to also make it compatible with Rails 7 + css-bundler (tailwind) + js-bundler (esbuild), which we need in order to use your awesome activeadmin_addons package.

Could you approve this and merge it in?

@joker-777
Copy link
Author

Sorry, I just realized that I created the PR based on my master branch where I pushed lots of other changes I need for my project. Unfortunately, it seems that activeadmin_addons isn't maintained anymore :(

@joker-777 joker-777 closed this Oct 19, 2022
@gap777
Copy link

gap777 commented Oct 19, 2022

@joker-777 So sad-- we really liked your changes here!

@gap777 gap777 mentioned this pull request Oct 19, 2022
@joker-777
Copy link
Author

Thanks, maybe I will create another PR but I doubt that there is anyone maintaining this repository.

@ldlsegovia
Copy link
Contributor

@joker-777 We're still alive, thankfully :) Creating a new PR with the sprockets related changes sounds good.

@joker-777
Copy link
Author

@ldlsegovia This is good news!!! I will try to create a new PR then.

Can you also have a look at my other PRs, please?
#419
#423

@difernandez
Copy link
Contributor

Hi all, sorry for the late comment. Wanted to let you know that we are planning a beta release for a new major version of this gem, which will drop support for sprockets, among other things. Theses changes will include the removal of sassc and sassc-rails dependencies. We’ll leave the related issues open for now, at least until the release of this version, but will be closing related PRs, as we might need to include similar changes in the removal of sprockets support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants