Added support for detecting change in objects with relations in nested-dirty.js #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-dirty.js This update enabled nested-dirty to detect changes of BelongsTo relations. For example, let's say I had an object with a `location` attribute that links to another model via BelongsTo, and I change the object in the `location` attribute to a different location object. Before this change would go unnoticed because related objects were skipped over when creating the $cmStatus. However, now, it saves the $pk of related objects to the $cmStatus, so it would now be able to detect that the `location` value changed (based on looking at the previous vs new location $pk).
|
@ldeboer This PR is quite old and out of date. Do you still have any interest in getting it included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enabled nested-dirty to detect changes of BelongsTo relations. For example, let's say I had an object with a
locationattribute that links to another model via BelongsTo, and I change the object in thelocationattribute to a different location object. Before this change would go unnoticed because related objects were skipped over when creating the $cmStatus. However, now, it saves the $pk of related objects to the $cmStatus, so it would now be able to detect that thelocationvalue changed (based on looking at the previous vs new location $pk).