Skip to content

Add Lolin32 Lite and TTGO T7 boards #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

balrog-kun
Copy link

Add Wemos Lolin32 Lite (original no longer being produced, same as Lolin32), TTGO
T7 v1.3 and v1.4 boards (status unknown). All three are rather generic ESP32 boards the
main difference being pin layout.

I use these from ESPHome which relies on the platformio board definitions. On top of it ESPHome has a per-board pin assignemtn registry (status LED pin, VBAT pin, etc.) where these boards actually differ.

Add Wemos Lolin32 Lite (no longer being produced, same as Lolin32), TTGO
T7 v1.3 and v1.4 boards.  All three are rather generic ESP32 boards the
main difference being pin layout.
@valeros
Copy link
Member

valeros commented Feb 17, 2021

Hi @balrog-kun !

Thanks for the PR. Users often complain about PlatformIO when they upload a simple blink example and it doesn't work because of the messed up pin layout. That's why we tend to add boards that have officially supported variants. The lolin32-lite board seems fine because you mentioned that it's the same as Lolin32, so I guess it has the same pin layout. As for the TTGO T7 boards, you specified ttgo-t7-v13-mini32 as the variant and I don't see anything close to that in the Arduino core for ESP32.

@balrog-kun
Copy link
Author

Thanks for the PR. Users often complain about PlatformIO when they upload a simple blink example and it doesn't work because of the messed up pin layout. That's why we tend to add boards that have officially supported variants. The lolin32-lite board seems fine because you mentioned that it's the same as Lolin32, so I guess it has the same pin layout.

Not really, it's a cut-down version and has fewer pins and the LED is on a different pin.

As for the TTGO T7 boards, you specified ttgo-t7-v13-mini32 as the variant and I don't see anything close to that in the Arduino core for ESP32.

Right, neither of the boards has arduino support. I added them locally in platform-espressif32, framework-arduinoespressif32 and esphome to be able to build for them, but I noticed that things would compile correctly even without the changes in framework-arduinoespressif32. So I wasn't sure what order to send pull requests in -- do you reckon I should first send a pull-request to arduino-esp32?

@balrog-kun
Copy link
Author

Oh, by saying

(original no longer being produced, same as Lolin32)

I meant that both have been retired by the original manufacturer (wemos) and only clones continue to be available.

@valeros
Copy link
Member

valeros commented Feb 17, 2021

Not really, it's a cut-down version and has fewer pins and the LED is on a different pin.

That's exactly what I was trying to say. Imagine how frustrating it is to upload a simple sketch that uses LED_BUILTIN and it doesn't work.

So I wasn't sure what order to send pull requests in -- do you reckon I should first send a pull-request to arduino-esp32?

Sounds like a good idea, Arduino IDE users will also benefit from your PR. Once they merge it and release a new stable version, I'll merge your PR here.

@balrog-kun
Copy link
Author

Done, so resuming this is now blocked by espressif/arduino-esp32#4819 and a subsequent arduino-esp32 release.

@valeros valeros closed this in ddab9bb Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants