add board definitions for unphone ESP32 and ESP32S3 devices #870
Conversation
|
Hi @hamishcunningham ! Thanks for the PR. Please see my comments above. |
|
Just to add, the PR to add variants to arduino-esp32 is now espressif/arduino-esp32#7109 |
|
Our pull request on arduino-esp32 has now been accepted |
|
Hi @hamishcunningham , thanks for the updates. Please review my comments above. |
|
Thanks for your patience reviewing our submission @valeros!! In addition to the changes you highlighted I have an additional question. "flash_mode": "dio", is this correct? On more careful review, other boards like ESP32-S3-DevKitC-1 have it as qio, indeed I see a recent fix that changed this. Thanks again! |
It seems you're using the QIO bootloader in the PR to the Arduino core, so it should be synchronized here as well. |
… ARDUINO_USB_MODE compile flags; load maximal partition map from Gareth
|
LGTM, the PR will be merged once a new stable version of ESP32 core is released. |
|
@valeros thank you, appreciate the update and glad that we have been able to address issues. good vibes to you! G |
|
hi @valeros can this be merged now that 2.0.5 of the core is released? tnx! h |
|
Thanks for the PR, merged! The boards will be available in the upcoming release of the dev-platform. |
|
Thank you!
…On Mon, 26 Sep 2022, 19:41 Valerii Koval, ***@***.***> wrote:
Thanks for the PR, merged! The boards will be available in the upcoming
release of the dev-platform.
—
Reply to this email directly, view it on GitHub
<#870 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBRBFC2IBX5JI4AMIOFJH3WAHU43ANCNFSM55PFAIIA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Board definitions for unphone boards: see https://iot.unphone.net/ and https://unphone.net/ for details.