-
-
Notifications
You must be signed in to change notification settings - Fork 42
Closed
Description
Lines 1 to 8 in d01ce73
import PlotlyBase | |
import JSON | |
function DashBase.to_dash(p::PlotlyBase.Plot) | |
data = JSON.lower(p) | |
pop!(data, :config, nothing) | |
return data | |
end |
Lines 1 to 7 in d01ce73
import JSON | |
function DashBase.to_dash(p::PlotlyJS.SyncPlot) | |
data = JSON.lower(p.plot) | |
pop!(data, :config, nothing) | |
return data | |
end |
are defining DashBase.to_dash
methods on type the Dash module does not own. This is type-piracy!
We should move these method definitions to https://github.com/plotly/DashBase.jl inside package extension modules with PlotlyBase.jl and PlotlyJS.jl as weakdeps.
Metadata
Metadata
Assignees
Labels
No labels