Skip to content

Updates for new repo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 30, 2025
Merged

Updates for new repo #1

merged 14 commits into from
Jan 30, 2025

Conversation

emilykl
Copy link
Collaborator

@emilykl emilykl commented Jan 17, 2025

The current state of the main branch is an exact copy of the packages/python/chart-studio directory as of Jan 2024.

This PR adds a few minor changes to account for this package being moved to its own repository:

  • Migrates the CircleCI job for running chart-studio tests (which was previously part of .circleci/config.yml in the Plotly.py repo) to a Github Action, and updates the job so that the tests run successfully
  • Adds a release.md containing the section of the Plotly.py release.md doc which are relevant to Chart Studio
  • Updates the project URL and tags in setup.py

Add short explanation of reorg in README
Copy link

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM yay

@marthacryan
Copy link

Oh wait actually - why is this not running in the CI?

Clarify that this repository does not contain code for the Chart Studio web service
@emilykl
Copy link
Collaborator Author

emilykl commented Jan 29, 2025

Oh wait actually - why is this not running in the CI?

@marthacryan I didn't want to enable the CI because it doesn't currently pass. (It wasn't being run at all in the Plotly.py repo.)

I agree it's not great to have a CI workflow just hanging around that we're not using though. I'll take a bit more time today to see if I can get it to pass... if not, plausibly we should just delete it.

@emilykl emilykl merged commit 44c7c43 into main Jan 30, 2025
1 check passed
@emilykl emilykl deleted the updates-for-new-repo branch January 30, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants