Skip to content

React 16.13 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 10, 2020
Merged

React 16.13 #92

merged 10 commits into from
Mar 10, 2020

Conversation

Marc-Andre-Rivet
Copy link
Contributor

Companion to plotly/dash#1145


delete Input.prototype.componentWillMount;
delete Input.prototype.componentWillReceiveProps;
delete Input.prototype.componentWillUpdate;
Copy link
Contributor Author

@Marc-Andre-Rivet Marc-Andre-Rivet Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is old and not maintained, this makes it work without warnings in React 16.12+

@Marc-Andre-Rivet Marc-Andre-Rivet changed the title React 16.12 React 16.13 Mar 6, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review March 6, 2020 20:50
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 49cc79d into master Mar 10, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the exp-react-16.12 branch March 10, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants