add thumbnail_size property #34
Conversation
emmanuelle
changed the title
I'm not sure if Pillow allows this. Pillow seems to consider the given size as a hint. Which is why we have Another nice addition would be to select a better default size when the data is very anisotropic. I noticed too that with the xray app the low-res data is way too low-res :P BTW: I suspect that we're using different versions of Black (CI runs the latest). |
emmanuelle
changed the title
|
Ready for review. I tested this on the xray app of the gallery. Probably I should add more tests and an example :-). |
dash_slicer/slicer.py
Outdated
| thumbnail_size (int or None): linear size of low-resolution data to be | ||
| uploaded to the client. If ``None``, the full-resolution data are | ||
| uploaded client-side. |
There was a problem hiding this comment.
Feeling a bit uncomfortable about the None which is often used to denote a default value. What about just thumbnail, which can be set to True/False, but also allowing an int with the size? Once we've fixed the anisotropy thing, the default size should be fine in nearly all cases.
Let's also mention the default size here.
dash_slicer/slicer.py
Outdated
| @property | ||
| def thumbnail_size(self): |
There was a problem hiding this comment.
Not sure if we need a public prop for this. Or do you have a use-case in mind?
dash_slicer/slicer.py
Outdated
| if self._thumbnail_size is None: | ||
| thumbnail_size = None | ||
| info["lowres_size"] = info["size"] | ||
| else: |
There was a problem hiding this comment.
Maybe a check here to make thumbnail_size None when the given size is larger than the image size?
|
This is nice! |
|
Thanks for the review @almarklein ! |
|
This PR looks good to go. Do you know what's up with the circleci build, @emmanuelle ? |
[Updated]
This PR introduces a
thumbnail_sizeproperty of the slicer, in order to be able to choose the size of the low-resolution images uploaded and available clientside. It is an integer, or None, in which case the full resolution data is uploaded clientside (I implemented this by not attaching the server callback, which was an easy solution).