Skip to content

Bump Flask due to https://github.com/pytest-dev/pytest/issues/5532 #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

wbrgss
Copy link
Contributor

@wbrgss wbrgss commented Aug 27, 2020

Pins Flask in requires-install.txt to v1.0.4 in order to avoid pytest-dev/pytest#5532 (using assert in tests is broken). I suppose this could be in requires-testing.txt but I don't think it's too risky. Latest version is v1.1.2 (https://flask.palletsprojects.com/en/1.1.x/changelog/)

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follow
    • this github #PR number updates the dash docs
    • here is the show and tell thread in plotly dash community

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbrgss this seems like a good idea, though unlikely to have practical consequences for most people at this point. 💃

@wbrgss wbrgss marked this pull request as ready for review December 8, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants