Skip to content

remove misleading py3.9 from snapshot names #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

graingert-coef
Copy link
Contributor

@graingert-coef graingert-coef commented Feb 6, 2024

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • remove misleading py3.9 from snapshot names
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@alexcjohnson
Copy link
Collaborator

@T4rk1n FYI I guess this is going to change the behavior for any other components that use percy_snapshot - next time they upgrade Dash (or next time they test, if they build Dash from the dev branch) their snapshots won't have the Python version in the name. I think this is the right way to go, we long ago stopped taking snapshots in all the Python versions we test, and anyone that still does want this version number in their snapshots can add it themselves pretty easily.

@alexcjohnson alexcjohnson requested a review from T4rk1n February 6, 2024 16:22
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💃

@alexcjohnson
Copy link
Collaborator

Ha all the tests passed first try except one of the Py3.6 jobs that's now on its third try. Since we're about to remove 3.6 entirely, if it doesn't pass this time I'll just merge anyway

@alexcjohnson alexcjohnson merged commit b1a72af into plotly:dev Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants