localizing the scope of the resize handler #3265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvwilson
added
P1
T4rk1n
reviewed
Apr 9, 2025
| @@ -14,7 +14,7 @@ const ResizeDetector = props => { | |||
| if (resizeTimeout) { | |||
| clearTimeout(resizeTimeout); | |||
| } | |||
| resizeTimeout = setTimeout(() => { | |||
| var resizeTimeout = setTimeout(() => { | |||
There was a problem hiding this comment.
Should be replaced with let and remove the global one on line 7.
ndrezn
reviewed
Apr 9, 2025
| @@ -205,5 +206,6 @@ def update_figures(n_clicks): | |||
| dash_dcc.wait_for_text_to_equal("#generate-btn", "Generate Figures") | |||
| dash_dcc.find_element("#generate-btn").click() | |||
| dash_dcc.wait_for_text_to_equal("#bounding-output", "loaded") | |||
| time.sleep(.1) ## must wait for the full render | |||
There was a problem hiding this comment.
Always a bit skeptical of adding artificial sleeps to load times. Is there any way we can actually await the full render?
There was a problem hiding this comment.
The components are there immediately, the debounce has a 50ms delay. I'm not sure there is a way to handle this.
I'm open to figuring out how to delay and wait for something on the screen to demonstrate the proper sizing. XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localizing the scope of the resize handler