-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
dcc redesign: accumulated bugfixes #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@T4rk1n @AnnMarieW if you have time to do a review, it would be very welcome - thanks |
This is great! Just a couple comments:
|
Also, any other comments on the issues raised in #3449? |
2d1cfe3
to
a2c28b7
Compare
This PR addresses most of what's in #3449, except for the cross-component consistency portion. I'd like to tackle that portion as a separate PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the docstring for the new prop should be changed.
This PR addresses issues/bugs reported so far in the existing redesigned components:
step
in sliders and add relevant testslocalizations
prop to dropdowns to allow customization of hard-coded texthtmlFor
prop not working)className
in slider so that it is applied at the top level of the component.To see the fixes one-by-one, just go through the commits.