Skip to content

Conversation

KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Sep 30, 2025

This PR addresses issues/bugs reported so far in the existing redesigned components:

  • fix bug with step in sliders and add relevant tests
  • add localizations prop to dropdowns to allow customization of hard-coded text
  • improve display of very long (wide) dropdown options
  • improve accessibility of dropdown & option lists (screen reader improvements and fix labels' htmlFor prop not working)
  • add visual focus state to inputs
  • add CSS variables for shadow colours
  • fix className in slider so that it is applied at the top level of the component.

To see the fixes one-by-one, just go through the commits.

@KoolADE85 KoolADE85 changed the base branch from dev to v4 September 30, 2025 00:03
@KoolADE85 KoolADE85 marked this pull request as ready for review September 30, 2025 00:19
@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 1, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Oct 1, 2025

@T4rk1n @AnnMarieW if you have time to do a review, it would be very welcome - thanks

@AnnMarieW
Copy link
Collaborator

AnnMarieW commented Oct 1, 2025

This is great! Just a couple comments:

  • Good that the focused state style was added on the Inputs, but can it be more subtle? - like the focus of the search box in the Dropdown?

  • Can a disabled state style also be added? In previous version the background was a gray color. Or for consistency, it could have the same cursor style as when the Dropdown is disabled.

Input:
image

Dropdown
image

@AnnMarieW
Copy link
Collaborator

Also, any other comments on the issues raised in #3449?

@KoolADE85 KoolADE85 force-pushed the bugfix/dcc-redesign-bugfixes branch from 2d1cfe3 to a2c28b7 Compare October 2, 2025 19:18
@KoolADE85
Copy link
Contributor Author

This PR addresses most of what's in #3449, except for the cross-component consistency portion. I'd like to tackle that portion as a separate PR!

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the docstring for the new prop should be changed.

@KoolADE85 KoolADE85 merged commit 391f0c8 into v4 Oct 3, 2025
9 checks passed
@KoolADE85 KoolADE85 deleted the bugfix/dcc-redesign-bugfixes branch October 3, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants