Skip to content

Add some new / missing plot icons #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Add some new / missing plot icons #12

merged 3 commits into from
Feb 27, 2018

Conversation

aulneau
Copy link
Contributor

@aulneau aulneau commented Jan 16, 2018

This update adds some 3d plot icons along with some other missing icons from @jackparmer's zip that he uploaded here.

@VeraZab I modified the import order a little bit -- whenever I add new icons I mass copy the paths to the .js files and so they are ordered alphabetically. I kept the separation of plot/non-plot icons.

I also renamed a few icons so we can have the convention of plot-3d-* or plot-2d-*. If any of the names look off, let me know and I can change them, eg plot-3d-line vs plot-line-3d.

@aulneau aulneau requested a review from VeraZab January 16, 2018 19:46
@VeraZab
Copy link
Contributor

VeraZab commented Jan 16, 2018

@aulneau the naming of plot icons should stem from the plotly.js convention of naming plots, because remember in the editor, we're looking for these icons by doing:
Plot${type}Icon

So for example, plotly.js names mesh 3d plots: mesh3d, so the name should be PlotMesh3dIcon
, and svg: plot-mesh3d.svg

A week back I renamed our svg files to match that plotly.js convention. To see all plot names you can go to https://plot.ly/create/, in the console do: Plotly.PlotSchema.get().traces

and you'll get all plotly.js trace names

@aulneau
Copy link
Contributor Author

aulneau commented Feb 19, 2018

Hey @VeraZab !

I've updated this again to reflect the updates I've been making in the editor repo -- we have most of the icons but we are missing a few :)

screen shot 2018-02-19 at 9 59 30 am

Missing:

table
pointcloud
2d contour histogram

I'll be adding the fancy new trace types that fab made shortly! just waiting on an updated export of the svgs

@VeraZab
Copy link
Contributor

VeraZab commented Feb 20, 2018

this is great, thanks!
@fabric-8 would you be able to make us icons for these:
table
pointcloud
2d contour histogram

Or are you already?
Thanks : )

@aulneau aulneau merged commit bdc4279 into master Feb 27, 2018
@dmt0 dmt0 deleted the update-plot-icons branch April 4, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants