You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is clearly a bug, but before I fix it, it'd be nice to have a discussion on how best to implement the ribbon in geom_smooth().
Alex mentioned that each ribbon should should be 2 traces, so that upon hover in compare mode, we can compare the top and bottom. I definitely agree that would be useful. My question however is: why isn't geom_ribbon() implemented this way?
The current approach is basically to treat geom_smooth() as geom_line() + geom_ribbon(). So if we re-implement geom_ribbon() as 2 traces, that change should propagate to geom_smooth().
geom_ribbon has both aes(fill) and aes(color), so if we want to be able to translate both of those to plotly I think we should treat it as a basic polygon (like geom_rect, see #178). To support comparing top and bottom values, I propose that we add an invisible error bar for each ribbon.
A user tried to recreate the following example in plotly.
However, the plotly result is:
This is clearly a bug, but before I fix it, it'd be nice to have a discussion on how best to implement the ribbon in
geom_smooth()
.Alex mentioned that each ribbon should should be 2 traces, so that upon hover in compare mode, we can compare the top and bottom. I definitely agree that would be useful. My question however is: why isn't
geom_ribbon()
implemented this way?The current approach is basically to treat
geom_smooth()
asgeom_line() + geom_ribbon()
. So if we re-implementgeom_ribbon()
as 2 traces, that change should propagate togeom_smooth()
.Thoughts @tdhock @chriddyp @mkcor?
The text was updated successfully, but these errors were encountered: