Skip to content

Bar / histogram traces break on single-ended (zoom) axis drag #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Dec 14, 2016 · 2 comments · Fixed by #1370
Closed

Bar / histogram traces break on single-ended (zoom) axis drag #1251

alexcjohnson opened this issue Dec 14, 2016 · 2 comments · Fixed by #1370
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

  • Make a bar or histogram plot. To see it even more clearly, use a plot with bars and something else like scatter - for example http://localhost:3000/devtools/test_dashboard/#bar_line
  • Position your mouse over an axis end or corner dragger - anywhere the mouse cursor becomes a single-ended arrow
  • Drag. The scatter or other traces stay scaled correctly as the axis/axes zoom. The bar trace(s) don't, they just pan.
@alexcjohnson alexcjohnson added the bug something broken label Dec 14, 2016
@rpaskowitz
Copy link
Contributor

The issue seems to be slightly more subtle (or has changed since originally reported)

  • If you are dragging from the low end of the X axis or the high end of the Y axis, then the bars appear to pan, but moving far further than they aught to, but
  • If you are dragging from the high end of the X axis, or the low end of the Y axis, then the bars do not move until a click-up event, at which point they redraw.

Fairly easy to see on these mocks as well, with the rendering being corrected once the users stopps the drag.
http://localhost:3000/devtools/test_dashboard/#basic_bar
http://localhost:3000/devtools/test_dashboard/#stacked_bar
http://localhost:3000/devtools/test_dashboard/#grouped_bar

@etpinard
Copy link
Contributor

This is a side effect of @rreusser #762 where

subplot.plot
  .selectAll('.points').selectAll('.point')

(unfortunately) also selects <g points> nodes in bar traces. Easy fix coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants