-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Description
that is 3D hover labels are broken in bundles built from a fresh --- fixed in npm i
v1.21.3
Commit mikolalysenko/mouse-change@2aba950 and more precisely this line ensured that mouse change listeners could be detached. Unfortunately, our gl3d scene code relied on the old (mouse-change@1.3.0
) buggy behavior here.
Removing that above line
scene.glplot.mouseListener.enabled = false;
in plots/gl3d/scene.js
appears to solve the issue. But, I afraid that it might lead to side-effects such as memory leaks. We should look into this in depth before merging a patch.
Metadata
Metadata
Assignees
Labels
bugsomething brokensomething broken
Type
Projects
Relationships
Development
Select code repository
Activity
etpinard commentedon Dec 22, 2016
cc @dfcreative @alexcjohnson
rreusser commentedon Jan 16, 2017
Am I correct in understanding that plotly simply doesn't use
mouseListener.enabled = true
anywhere? Or if that command was broken, perhaps it does use it even though it requests not to. At least I'm not immediately able to find a reference to where it is used. It sounds like that might indeed leak a bit of memory then if listeners are reattached but never detached. Perhaps they only leak on initializeGLPlot? That doesn't sound horrible.This is a bit confusing.