Skip to content

3D hover labels don't show up with mouse-change@1.4.0 #1268

@etpinard

Description

@etpinard
Contributor

that is 3D hover labels are broken in bundles built from a fresh npm i --- fixed in v1.21.3

Commit mikolalysenko/mouse-change@2aba950 and more precisely this line ensured that mouse change listeners could be detached. Unfortunately, our gl3d scene code relied on the old (mouse-change@1.3.0) buggy behavior here.

Removing that above line

 scene.glplot.mouseListener.enabled = false;

in plots/gl3d/scene.js appears to solve the issue. But, I afraid that it might lead to side-effects such as memory leaks. We should look into this in depth before merging a patch.

Activity

etpinard

etpinard commented on Dec 22, 2016

@etpinard
ContributorAuthor
added this to the v1.22.0 milestone on Jan 4, 2017
self-assigned this
on Jan 6, 2017
rreusser

rreusser commented on Jan 16, 2017

@rreusser
Contributor

Am I correct in understanding that plotly simply doesn't use mouseListener.enabled = true anywhere? Or if that command was broken, perhaps it does use it even though it requests not to. At least I'm not immediately able to find a reference to where it is used. It sounds like that might indeed leak a bit of memory then if listeners are reattached but never detached. Perhaps they only leak on initializeGLPlot? That doesn't sound horrible.

This is a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugsomething broken

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @rreusser@etpinard

    Issue actions

      3D hover labels don't show up with `mouse-change@1.4.0` · Issue #1268 · plotly/plotly.js