Skip to content

support dom element as argument to Plotly.makeTemplate #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Conversation

antoinerg
Copy link
Contributor

As a first-time user of templates, I expected the following to just work:

var.gd = document.getElementById('graph');
Plotly.plot(gd,{...});2,3], y:[4,9,3], line: {color: 'red'}}
...
var layout = Plotly.makeTemplate(gd);

This PR enables calling makeTemplate with a DOM element.

@antoinerg antoinerg self-assigned this Oct 16, 2018
@alexcjohnson
Copy link
Collaborator

Thanks @antoinerg - beautiful test. After the indentation fix, 💃 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants