Skip to content

Discard negative values from pie chart post-aggregation instead of during summation #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Discard negative values from pie chart post-aggregation instead of during summation #6051

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
445ada3
Drop negative values post-aggregation instead of during summation in …
destiny-wu Dec 4, 2021
3e58fc2
Include labels with value >= 0
destiny-wu Dec 8, 2021
ddea216
Update baseline image
destiny-wu Dec 8, 2021
1331ad8
Rename pie-negative-values png and json files to begin with z-
destiny-wu Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/traces/pie/calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ function calc(gd, trace) {
v = vals[i];
if(!isNumeric(v)) continue;
v = +v;
if(v < 0) continue;
} else v = 1;

label = labels[i];
Expand Down Expand Up @@ -76,6 +75,9 @@ function calc(gd, trace) {
}
}

// Drop aggregate sums of value 0 or less
cd = cd.filter(function(elem) { return elem.v > 0; });

var shouldSort = (trace.type === 'funnelarea') ? isAggregated : trace.sort;
if(shouldSort) cd.sort(function(a, b) { return b.v - a.v; });

Expand Down
42 changes: 42 additions & 0 deletions test/image/mocks/pie_negative_values.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"data": [
{
"labels": [
"Apples",
"Apples",
"Bananas",
"Oranges",
"Pears",
"Pears",
"Apples",
"Pears"
],
"type": "pie",
"domain": {"x": [0, 0.4]}
},
{
"labels": [
"Apples",
"Apples",
"Bananas",
"Oranges",
"Pears",
"Pears",
"Apples",
"Pears"
],
"values": [
10, -20, 20, 40, 10, -20, 70, 5
],
"marker": {"colors": ["", "", "#ccc"]},
"type": "pie",
"domain": {"x": [0.5, 1]},
"textinfo": "label+value+percent"
}
],
"layout": {
"height": 300,
"width": 500
}
}