Fix hover label after resize bug #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- looks like fullLayout._plots does not get updated properly on resize. Fixing that deserves a PR of its own. - this commit reverts to the pre-#575 behavior
|
|
||
| // TODO make sure that fullLayout_plots axis refs | ||
| // get updated properly so that we don't have | ||
| // to use Axes.getFromId in general. |
There was a problem hiding this comment.
Can you open an issue for this so we don't forget?
There was a problem hiding this comment.
Sure. Done in #634
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #606
by grabbing refs to x/y axis using
Axes.getFromIdinstead of looking intofullLayout._plots-as it was done before commit 858a338 .
But really, the axis refs in
fullLayout._plotsshould always be up-to-date. A future maintenance PR should address this.