Automargin zoom

draftlogs/6312_fix.md

@@ -0,0 +1 @@
+Fix bug with automargin and axis titles [[#6312](https://github.com/plotly/plotly.js/pull/6312)]

src/plot_api/plot_api.js

@@ -1888,8 +1888,6 @@ function addAxRangeSequence(seq, rangesAltered) {
                         }
                     }
                 }
-
-                if(ax.automargin) skipTitle = false;
             }
 
             return Axes.draw(gd, axIds, {skipTitle: skipTitle});

test/image/mocks/z-automargin-zoom.json

@@ -0,0 +1,60 @@
+{"data": [{
+    "showlegend": false,
+    "type": "scatter",
+    "x": [
+      "@100000001",
+      "@100000002",
+      "@100000003",
+      "@100000004",
+      "@100000005",
+      "@100000006",
+      "@100000007",
+      "@100000008",
+      "@100000009",
+      "@100000010",
+      "@100000011",
+      "@100000012",
+      "@100000013",
+      "@100000014",
+      "@100000015",
+      "@100000016",
+      "@100000017",
+      "@100000018",
+      "@100000019"
+    ],
+    "xaxis": "x",
+    "y": [
+      100,
+      101,
+      99,
+      101,
+      98,
+      97,
+      101,
+      102,
+      109,
+      110,
+      110,
+      102,
+      93,
+      114,
+      115,
+      115,
+      171,
+      185,
+      190
+    ],
+    "yaxis": "y"
+  }],
+  "layout": {
+    "height": 400,
+    "width": 700,
+    "xaxis": {
+      "title": {"text": "Revision"},
+      "automargin": true
+    },
+    "yaxis": {
+      "automargin": true
+    }
+  }
+}

test/jasmine/tests/axes_test.js

@@ -4376,6 +4376,37 @@ describe('Test axes', function() {
             })
             .then(done, done.fail);
         });
+        it('should respect axis title placement on relayout', function(done) {
+
+            function getPos(gd, sel) {
+                return d3Select(gd).select(sel).node().getBoundingClientRect()
+            }
+
+            function assertLayout() {
+                var titleTop = getPos(gd, '.xtitle').top;
+                var tickBottom = getPos(gd, '.xtick').bottom;
+                expect(tickBottom).toBeLessThan(titleTop);
+            }
+            // TODO: This is failing now. 
+            // Is it maybe because there's overlap in these elements because of some padding?
+            // I'm also not sure that I've accessed the correct properties
+            var fig = require('@mocks/z-automargin-zoom.json');
+
+            Plotly.newPlot(gd, fig)
+            console.log(d3Select(gd).select('.xtitle').node().getBoundingClientRect().top)
+            console.log(d3Select(gd).select('.xtitle').node().getBoundingClientRect().bottom)
+
+            .then(function() {
+                assertLayout(); 
+            })
+            .then(function() {
+                return Plotly.relayout(gd, {'xaxis.range': [6, 14]});
+            })
+            .then(function() {
+                assertLayout();
+            })
+            .then(done, done.fail);
+        });
     });
 
     describe('zeroline visibility logic', function() {