Fix exporting transparent colors in rangeslider & selections
#6323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Oct 5, 2022
src/components/rangeslider/draw.js
Outdated
| fill: fillRGB, | ||
| 'fill-opacity': fillAlpha, | ||
| stroke: strokeRGB, | ||
| 'stroke-opacity': strokeAlpha, |
There was a problem hiding this comment.
🌴 better to reuse Color.stroke and Color.fill here and in selections/select.js - and that would also help address the presumably unintentional use of attr here whereas elsewhere we use style for these.
To be specific, you can either:
bg.attr({...})
.call(Color.stroke, opts.bordercolor)
.call(Color.fill, opts.bgcolor);or:
bg.attr({...});
Color.stroke(bg, opts.bordercolor);
Color.fill(bg, opts.bgcolor);
alexcjohnson
reviewed
Oct 5, 2022
src/traces/violin/hover.js
Outdated
| violinLineAttrs = { | ||
| stroke: strokeRGB, | ||
| 'stroke-opacity': strokeAlpha | ||
| }; |
There was a problem hiding this comment.
This one would take a little more work to convert to Color.stroke - basically stashing strokeC so it can be used below next to the call
violinLine.attr(violinLineAttrs);But I still think it'd be a good idea, and again there's the attr/style switch. In principle both work but we should really be consistent, as there can be different behavior in relation to extra CSS on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6318 | @alexcjohnson
There are few more instances in
hoverthat we could fix; but since we don't export hovers (yet), I thought we may want to skip for now.