-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Position title after legend width calculated #6725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
236e3c7
Position title after legend width calculated
wkelsey-apple be70669
better method to horizontal align the title
28raining ab114f8
Update color-parse for case-insensitive fix. Lint.
28raining 40e8c6a
Adding fix for issue 6661
28raining 6d83f4a
updating mock so title is an object
28raining 4404f94
regenerating some identical mocks...
28raining 646a6bc
flipping logic to check user-def bin groups...
28raining 147ddcb
remove + re-add baselines (git not see image chg?)
28raining 76385d2
re-add baselines
28raining 8ccef98
rename mock to zz_ to workaround circleci issue
28raining b7a98e2
Adding PR draft.md
wkelsey-apple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
``` | ||
- Fix horizontal title alignment [[#6668](https://github.com/plotly/plotly.js/issues/6668)] | ||
- Fix single-point histogram when user has provided bin widths [[#6661](https://github.com/plotly/plotly.js/issues/6661)] | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"x": ["2023-05-22 09:29:56.00"], | ||
"opacity": 1, | ||
"type": "histogram", | ||
"name": "Results B", | ||
"marker": { | ||
"color": "rgba(0, 255, 0, .2)", | ||
"line": { | ||
"color": "rgba(0, 255, 0, 1)", | ||
"width": 2 | ||
} | ||
}, | ||
"xbins": { | ||
"size": "M1", | ||
"start": "2023-05-01", | ||
"end": "2023-07-01" | ||
} | ||
}, | ||
{ | ||
"x": ["2023-05-21 09:29:56.00", "2023-05-26 09:29:56.00", "2023-06-21 09:29:56.00"], | ||
"opacity": 1, | ||
"type": "histogram", | ||
"name": "Results A", | ||
"marker": { | ||
"color": "rgba(0, 0, 255, .2)", | ||
"line": { | ||
"color": "rgba(0, 0, 255, 1)", | ||
"width": 2 | ||
} | ||
}, | ||
"xbins": { | ||
"size": "M1", | ||
"start": "2023-05-01", | ||
"end": "2023-07-01" | ||
} | ||
} | ||
], | ||
"layout": { | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"barmode": "overlay", | ||
"title": { "text": "Sampled Results" }, | ||
"xaxis": { | ||
"title": { "text": "Date" } | ||
}, | ||
"yaxis": { "title": { "text": "Count" } } | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.