Fix resizing pie
like traces when textinfo
is set to "none"
#6893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
textinfo==="none"
, thetextposition
coercion is skipped for both funnelarea and pie traces. However, there is a place in the plot render logic that assumestextposition
is defined and is skipped ifftextposition==="none"
(https://github.com/plotly/plotly.js/blob/master/src/traces/pie/plot.js#L136).Since the coercion is not enforced and
textposition
is undefined (not"none"
), related text objects which have not been initialized are attempted to be accessed resulting in a null pointer exception (https://github.com/plotly/plotly.js/blob/master/src/traces/pie/plot.js#L511).I am open to alternative solutions that may include a
textinfo==="none"
check in the plot render logic, but this approach seemed to be the most comprehensive.Reproduction example: https://github.com/robbtraister/plotly-npe