Skip to content

fix getFullTransformMatrix in shadow DOM #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2024
Merged

fix getFullTransformMatrix in shadow DOM #6996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
066abae
fix getFullTransformMatrix in shadow DOM
OpportunityLiu May 14, 2024
3764395
Add draft log
OpportunityLiu May 14, 2024
465aef4
fix getFullTransformMatrix in shadow DOM
OpportunityLiu May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions draftlogs/6996_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix `getFullTransformMatrix` in shadow DOM [[#6996](https://github.com/plotly/plotly.js/pull/6996)],
with thanks to @OpportunityLiu for the contribution!
3 changes: 3 additions & 0 deletions src/lib/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ function getElementAndAncestors(element) {
while(isTransformableElement(element)) {
allElements.push(element);
element = element.parentNode;
if(typeof ShadowRoot === 'function' && element instanceof ShadowRoot) {
element = element.host;
}
}
return allElements;
}
Expand Down