Skip to content

Reifies not yet covered, preexisting behavior of Lib.extendDeep #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Reifies not yet covered, preexisting behavior of Lib.extendDeep #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions test/jasmine/tests/extend_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ var undef = {
arr: [1, 2, undefined]
};

var undef2 = {
str: undefined,
layer: {
date: undefined
},
arr: [1, undefined, 2]
};


describe('extendFlat', function() {
'use strict';
Expand Down Expand Up @@ -376,7 +384,7 @@ describe('extendDeep', function() {

expect(ori).toEqual({
layer: { },
arr: [1, 2 ]
arr: [1, 2]
});
expect(undef).toEqual({
str: undefined,
Expand All @@ -387,7 +395,33 @@ describe('extendDeep', function() {
});
expect(target).toEqual({
layer: { },
arr: [1, 2 ]
arr: [1, 2]
});
});

it('leaves a gap in the array for undefined of lower index than that of the highest defined value', function() {
ori = {};
target = extendDeep(ori, undef2);

var compare = [];
compare[0] = 1;
// compare[1] left undefined
compare[2] = 2;

expect(ori).toEqual({
layer: { },
arr: compare
});
expect(undef2).toEqual({
str: undefined,
layer: {
date: undefined
},
arr: [1, undefined, 2]
});
expect(target).toEqual({
layer: { },
arr: compare
});
});

Expand Down