Skip to content

fix hover event not triggered on consecutive empty bins (count=0) with hovermode:'x' for histogram #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 4, 2025
Merged

fix hover event not triggered on consecutive empty bins (count=0) with hovermode:'x' for histogram #7503

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f22c3d9
fix hover event issue for histogram
Lexachoc Jul 31, 2025
314e29d
Create 7503_fix.md
Lexachoc Jul 31, 2025
280600d
Add test for bin number change
camdecoster Aug 1, 2025
5afcdd4
Update src/components/fx/hover.js
Lexachoc Aug 1, 2025
9c92a2b
Update 7503_fix.md
Lexachoc Aug 3, 2025
80606da
Update 7503_fix.md
camdecoster Aug 4, 2025
7f765e4
Fix typo in 7503_fix.md
camdecoster Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/7503_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix hover event not triggered on consecutive empty bins (count=0) with `hovermode:'x'` for histogram[[#7503](https://github.com/plotly/plotly.js/pull/7503)]
3 changes: 2 additions & 1 deletion src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2283,7 +2283,8 @@ function hoverChanged(gd, evt, oldhoverdata) {

if(oldPt.curveNumber !== newPt.curveNumber ||
String(oldPt.pointNumber) !== String(newPt.pointNumber) ||
String(oldPt.pointNumbers) !== String(newPt.pointNumbers)
String(oldPt.pointNumbers) !== String(newPt.pointNumbers) ||
String(oldPt.binNumber) !== String(newPt.binNumber)
) {
return true;
}
Expand Down