Don't use child_process.exec to setup docker container on CircleCI
#853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move them to tasks/run_docker.js and tasks/setup_docker.js respectively - make circle.yml eval $() string output from node script instead of using child process exec
|
Let's try this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a lot of intermittent test failure on CircleCI during the
npm run pretesttest ever since #821 got merged and #849 does not seem to help much.So I decided to dumb down the pretest step. Instead of having one node script that does it all, this PR split the docker container tasks in two steps. These tasks are call using the shell
eval.cc @rreusser