Skip to content

Better error messages for (i)create_animations #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2016
Merged

Better error messages for (i)create_animations #628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b53e78
supported 5/9 of chris' suggested error msgs
Kully Dec 6, 2016
3993829
andrew's comments
Kully Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions plotly/plotly/plotly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,15 +1586,24 @@ def create_animations(figure, filename=None, sharing='public', auto_open=True):

api_url = _api_v2.api_url('plots')
r = requests.post(api_url, auth=auth, headers=headers, json=json)
r.raise_for_status()

try:
parsed_response = r.json()
except:
parsed_response = r.content

if 'error' in r and r['error'] != '':
raise exceptions.PlotlyError(r['error'])
# raise error message
if not r.ok:
message = ''
if isinstance(parsed_response, dict):
errors = parsed_response.get('errors')
if errors and errors[-1].get('message'):
message = errors[-1]['message']
if message:
raise exceptions.PlotlyError(message)
else:
# shucks, we're stuck with a generic error...
r.raise_for_status()

if sharing == 'secret':
web_url = (parsed_response['file']['web_url'][:-1] +
Expand Down