This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Support implicit dataframe argument. #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't have tests or graceful error messages yet, but it seems functional. |
|
Thanks for this! I'll take a closer look at it in a couple of days with an eye towards supporting #37 by extending it :) |
|
So I really like this, but I'd like to roll it out with support for #37 and I don't think I have the bandwidth to do so before the Plotly.py v4 release, at which point this repo will disappear and the code will move to the plotly.py repo. OK with you if I close this PR and port the patch into the library after the v4 move in July? |
|
Sure. |
|
This will be implemented as part of plotly/plotly.py#1767 ... thanks for the input and patience :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85.