fix: Ensure Changed-only queries do not pick up changes from unrelated traits #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r04423
commented
Aug 10, 2025
|
|
||
| return { | ||
| required: required | added, | ||
| required: required | added | changed, |
There was a problem hiding this comment.
Not 100% if it's correct place to fix the issue, but I assumed traits in Changed modifier should be considered as required
r04423
commented
Aug 10, 2025
| entity2.changed(Bar); | ||
|
|
||
| // Changed(Foo) should still return undefined | ||
| expect(world.queryFirst(Changed(Foo))).toBeUndefined(); |
There was a problem hiding this comment.
This assertion was previously failing
r04423
commented
Aug 10, 2025
|
|
||
| it.fails( | ||
| 'should not inlcude non-tracked traits in queries contaning only Removed modifier', | ||
| () => { |
There was a problem hiding this comment.
I can reproduce the same issue with Removed modifier, but here I wasn't entirely sure if the fix would be the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently queries containing only
Changedmodifier pick up changes from (seemingly) any trait, not only the one specified in the query parameterThis PR updates
requiredPR bit flag to includechanged, ensuring query behavior stays correct