-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat(types): create ogl augmented defs #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
474c1d9
to
9d61a3c
Compare
Good choose because i see that ogl-typescript has wrong and outdate definitions. |
I did reference ogl-typescript but came to the same conclusion. A bunch of depreciations were made since gLTF stuff was added, and it looks like they crudely auto-generated a bunch of stuff with some MS tools since the interfaces were confusingly incorrect or incomplete. I'm vetting types by hand, but I'm a few days into it now. I'll have to find a system to A/B these with OGL source and try it out on examples. |
Can possibly fill in OGL's uniform types based on allowed values -- float/ints, float/int arrays, samplers/samplerarrays, and structs. react-ogl allows some shorthand for Lines 216 to 229 in 1c9874e
|
Continuing in #51. See https://github.com/CodyJasonBennett/ogl-types for OGL types. |
Prob move to DefinitelyTyped or OGL org under
@types/ogl
. Related: oframe/ogl#24.