fix(parallax): remove extra targetScroll space #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #1022 which was applied to the wrong branch. |
this was causing some elements to have an extra viewport height gap. see issue for more details. fixes pmndrs#962
localjo
force-pushed
the
fix-parallax-math
branch
from
646a88c to
4d5b8a9
Compare
|
It appears that the build is failing due to |
This comment has been minimized.
This comment has been minimized.
joshuaellis
approved these changes
Mar 18, 2021
3 tasks
joshuaellis
pushed a commit
that referenced
this pull request
Apr 21, 2021
cameron-martin
pushed a commit
to cameron-martin/react-spring
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was causing some elements to have an extra viewport height gap. see issue for more details.
fixes #962