Add support for hoisting non-react statics #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the suggestion! I wasn't aware of that issue with HoC. I will merge your PR and prepare the new release shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all - not sure if hoisting non-react statics is of any interest to be supported as part of this library, but wanted to share my solution for non-react static values not being hoisted in the returned component. Just in case someone else can benefit from it.
Issue became evident as I was using
react-navigationandreact-debounce-renderat the same time. The latter would make the former not work sincereact-navigationnavigationOptionsare passed as static objects on a per-screen basis. Hoisting the non-react statics solves that.